Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove whitespace from http_path for databricks #22671

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

eschutho
Copy link
Member

SUMMARY

The databricks connector driver will error if there's a space in the http_path. Fixing this at the db engine spec level to catch at the lowest level. The ui for the database connection modal already strips on the client side, so adding an extra layer here for api handling.

TESTING INSTRUCTIONS

Curl the api with a trailing string in the http_path field for either validate/edit/or db connection. The connection should work regardless of any leading/trailing whitespace.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #22671 (2a0c84d) into master (71982ee) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #22671      +/-   ##
==========================================
+ Coverage   66.91%   67.08%   +0.16%     
==========================================
  Files        1850     1865      +15     
  Lines       70695    71387     +692     
  Branches     7750     7750              
==========================================
+ Hits        47309    47889     +580     
- Misses      21370    21482     +112     
  Partials     2016     2016              
Flag Coverage Δ
hive 52.60% <0.00%> (+0.13%) ⬆️
mysql 78.01% <50.00%> (+0.02%) ⬆️
postgres 78.08% <50.00%> (+0.02%) ⬆️
presto 52.49% <0.00%> (+0.12%) ⬆️
python 81.32% <100.00%> (+0.05%) ⬆️
sqlite 76.48% <50.00%> (-0.05%) ⬇️
unit 51.48% <100.00%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/databricks.py 66.19% <100.00%> (+0.48%) ⬆️
superset/db_engine_specs/impala.py 44.87% <0.00%> (-38.47%) ⬇️
superset/db_engine_specs/bigquery.py 69.60% <0.00%> (-12.09%) ⬇️
superset/dashboards/filter_state/commands/utils.py 80.00% <0.00%> (-10.00%) ⬇️
...uperset/dashboards/filter_state/commands/delete.py 91.30% <0.00%> (-4.35%) ⬇️
superset/databases/commands/update.py 75.86% <0.00%> (-4.14%) ⬇️
...uperset/dashboards/filter_state/commands/update.py 96.66% <0.00%> (-3.34%) ⬇️
superset/views/datasource/schemas.py 97.22% <0.00%> (-2.78%) ⬇️
superset/dao/base.py 92.78% <0.00%> (-2.62%) ⬇️
superset/examples/birth_names.py 70.00% <0.00%> (-1.43%) ⬇️
... and 51 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eschutho eschutho merged commit cd1f6d4 into apache:master Jan 13, 2023
@eschutho eschutho deleted the elizabeth/databricks-bugs branch January 13, 2023 22:50
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants