Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bootstraping frontend #22720

Merged
merged 1 commit into from
Jan 13, 2023
Merged

fix: bootstraping frontend #22720

merged 1 commit into from
Jan 13, 2023

Conversation

cdreier
Copy link
Contributor

@cdreier cdreier commented Jan 13, 2023

Fixes #22719 which is a regression from #22658

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing this!

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Merging #22720 (76a4078) into master (aeb45ea) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master   #22720   +/-   ##
=======================================
  Coverage   66.93%   66.93%           
=======================================
  Files        1869     1869           
  Lines       71608    71608           
  Branches     7821     7821           
=======================================
  Hits        47931    47931           
  Misses      21649    21649           
  Partials     2028     2028           
Flag Coverage Δ
javascript 53.90% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/middleware/asyncEvent.ts 78.18% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@villebro villebro merged commit 91850eb into apache:master Jan 13, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when booting the superset frontend
3 participants