fix: dataset_macro

[betodealmeida]

SUMMARY

The dataset() macro in SQL Lab doesn't work correctly when the SQL mutator wraps the query in comments. For example, with the following mutator:

def mutator(sql: str) -> str:
    return f"-- begin\n{sql}\n-- end"   

When using the macro:

SELECT * FROM {{ dataset(1) }}

The generated SQL looks like this:

SELECT * FROM (-- begin
SELECT ...
-- end) AS dataset_1

Which strips out the ) AS dataset_1 part, rendering the query invalid since it now misses a closing parenthesis.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #23376 (6a77d80) into master (d2c1fb9) will increase coverage by 0.15%.
The diff coverage is 100.00%.

❗ Current head 6a77d80 differs from pull request most recent head 12fb4d5. Consider uploading reports for the commit 12fb4d5 to get more accurate results

@@            Coverage Diff             @@
##           master   #23376      +/-   ##
==========================================
+ Coverage   67.36%   67.52%   +0.15%     
==========================================
  Files        1907     1907              
  Lines       73447    73448       +1     
  Branches     7976     7976              
==========================================
+ Hits        49477    49593     +116     
+ Misses      21921    21806     -115     
  Partials     2049     2049              

Flag	Coverage Δ
hive	52.76% <60.00%> (?)
mysql	78.43% <60.00%> (+<0.01%)	⬆️
postgres	78.49% <60.00%> (+<0.01%)	⬆️
presto	52.69% <60.00%> (?)
python	82.26% <100.00%> (+0.32%)	⬆️
sqlite	76.96% <60.00%> (+<0.01%)	⬆️
unit	52.45% <80.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/connectors/sqla/models.py	89.56% <100.00%> (+1.27%)	⬆️
superset/jinja_context.py	90.74% <100.00%> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more