chore(presto): Expose schema and indexes to _partition_query method #23674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
commented
Apr 13, 2023
superset/db_engine_specs/presto.py
Outdated
| cls, | ||
| schema: Optional[str], |
There was a problem hiding this comment.
Given this is a private method, changing the order of the function arguments is deemed non-breaking.
Codecov Report
@@ Coverage Diff @@
## master #23674 +/- ##
=======================================
Coverage 68.08% 68.09%
=======================================
Files 1920 1922 +2
Lines 73990 74041 +51
Branches 8092 8101 +9
=======================================
+ Hits 50379 50419 +40
- Misses 21540 21551 +11
Partials 2071 2071
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
john-bodley
force-pushed
the
john-bodley--presto-partition-query
branch
from
30c721e
to
8d2d14e
Compare
john-bodley
commented
Apr 13, 2023
|
|
||
| Note the unused arguments are exposed for sub-classing purposes where custom |
There was a problem hiding this comment.
@michael-s-molina per our offline discussion I added this comment as to why the unused arguments are included.
john-bodley
force-pushed
the
john-bodley--presto-partition-query
branch
2 times, most recently
from
f522aa8
to
c590a88
Compare
john-bodley
force-pushed
the
john-bodley--presto-partition-query
branch
from
c590a88
to
9cfc5ca
Compare
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Apr 14, 2023
…pache#23674) Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> (cherry picked from commit 100ccb7)
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Apr 26, 2023
…pache#23674) Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> (cherry picked from commit 100ccb7)
sebastianliebscher
pushed a commit
to sebastianliebscher/superset
that referenced
this pull request
Apr 28, 2023
…pache#23674) Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR exposes the schema and indexes to the internal (private)
PrestoBaseEngineSpec._partition_querymethod as these could be useful for custom overrides of the partition query.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION