Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump wtforms and add missing flask-limiter #23680

Merged
merged 10 commits into from
Apr 28, 2023

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Apr 13, 2023

SUMMARY

Bumps wtforms to the latest and adapt code to breaking changes. Also adds flask-limiter and it's dependencies since it's a new base requirement on flask-appbuilder

More details on the linked issue

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: Vulnerable issues (CVE) with dependencies in Superset #23621
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar changed the title deps: bump wtforms and add missing flask-limiter chore: bump wtforms and add missing flask-limiter Apr 13, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #23680 (e80cad8) into master (e805dec) will increase coverage by 1.73%.
The diff coverage is 100.00%.

❗ Current head e80cad8 differs from pull request most recent head 2c0493a. Consider uploading reports for the commit 2c0493a to get more accurate results

@@            Coverage Diff             @@
##           master   #23680      +/-   ##
==========================================
+ Coverage   66.25%   67.98%   +1.73%     
==========================================
  Files        1937     1937              
  Lines       74933    74929       -4     
  Branches     8137     8137              
==========================================
+ Hits        49645    50941    +1296     
+ Misses      23203    21903    -1300     
  Partials     2085     2085              
Flag Coverage Δ
hive 53.01% <100.00%> (?)
mysql 78.80% <100.00%> (+<0.01%) ⬆️
postgres ?
presto 52.92% <100.00%> (?)
python 82.59% <100.00%> (+3.58%) ⬆️
sqlite 77.39% <100.00%> (+<0.01%) ⬆️
unit 52.81% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/actions/sqlLab.js 66.41% <ø> (-0.09%) ⬇️
...d/src/SqlLab/components/SaveDatasetModal/index.tsx 50.53% <ø> (+0.53%) ⬆️
...frontend/src/explore/actions/datasourcesActions.ts 100.00% <ø> (ø)
superset/connectors/sqla/views.py 89.71% <100.00%> (ø)
superset/views/core.py 75.33% <100.00%> (+0.01%) ⬆️
superset/views/database/forms.py 93.75% <100.00%> (+0.07%) ⬆️

... and 99 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new clean _func prefixed params

@dpgaspar dpgaspar merged commit 31d3359 into apache:master Apr 28, 2023
@dpgaspar dpgaspar deleted the bump/wtforms branch April 28, 2023 14:31
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@SimonMikolajek
Copy link

Commit contains updates to base.txt which need to be merged once latest commit is pulled. Once incoming are an accepted build fails on pygments conflicts (it tries to install pygments==2.15.0 & pygments==2.12.0).
/requirements/developement.txt pygments needs to be changed/updated to pygments==2.15.0 as well

@mistercrunch mistercrunch added 🍒 2.1.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.1.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v2.1 🍒 2.1.2 🍒 2.1.3 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants