Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(slack): use recommended method for file upload #23744

Merged
merged 1 commit into from
May 8, 2023

Conversation

betodealmeida
Copy link
Member

SUMMARY

Use the files_upload_v2 method in the Slack client, instead of files_upload, see this thread.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Updated integration test.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #23744 (8ef4305) into master (f3f5d92) will increase coverage by 0.00%.
The diff coverage is 98.66%.

❗ Current head 8ef4305 differs from pull request most recent head f712752. Consider uploading reports for the commit f712752 to get more accurate results

@@           Coverage Diff           @@
##           master   #23744   +/-   ##
=======================================
  Coverage   68.17%   68.18%           
=======================================
  Files        1941     1941           
  Lines       75209    75241   +32     
  Branches     8155     8158    +3     
=======================================
+ Hits        51277    51306   +29     
- Misses      21849    21852    +3     
  Partials     2083     2083           
Flag Coverage Δ
hive 53.17% <99.47%> (+<0.01%) ⬆️
mysql 78.90% <100.00%> (+<0.01%) ⬆️
postgres 78.97% <100.00%> (+<0.01%) ⬆️
presto 53.09% <99.47%> (+<0.01%) ⬆️
python 82.75% <100.00%> (+<0.01%) ⬆️
sqlite 77.50% <100.00%> (+<0.01%) ⬆️
unit 52.98% <99.47%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...chart-echarts/src/MixedTimeseries/controlPanel.tsx 56.52% <ø> (ø)
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.00% <0.00%> (ø)
superset/datasource/api.py 100.00% <ø> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js 68.53% <100.00%> (+2.19%) ⬆️
superset/advanced_data_type/api.py 100.00% <100.00%> (ø)
superset/annotation_layers/annotations/api.py 89.31% <100.00%> (ø)
superset/annotation_layers/api.py 86.32% <100.00%> (ø)
superset/async_events/api.py 100.00% <100.00%> (ø)
superset/available_domains/api.py 100.00% <100.00%> (ø)
superset/cachekeys/api.py 96.15% <100.00%> (ø)
... and 38 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pull-request-size pull-request-size bot added size/L and removed size/S labels Apr 20, 2023
Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@betodealmeida betodealmeida force-pushed the slack_files_upload_v2 branch 2 times, most recently from 44a9ad2 to b27992b Compare April 26, 2023 23:43
@pull-request-size pull-request-size bot added size/M and removed size/L labels May 8, 2023
@betodealmeida betodealmeida merged commit 9fd936c into master May 8, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the slack_files_upload_v2 branch March 26, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants