-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-chart-handlebars): Fix TypeError when using handlebars columns raw mode #23801
fix(plugin-chart-handlebars): Fix TypeError when using handlebars columns raw mode #23801
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Running CI and pinging some additional reviewers. |
This PR seems to be stuck on a failing unit test. @fmannhardt I suspect a rebase from |
@fmannhardt This seems to be failing repeatedly on unit tests. Could be flaky tests, but I haven't investigated. You might get lucky with a rebase from |
b8537cc
to
fc6d026
Compare
I have rebased on current master and pushed the changes. |
Codecov Report
@@ Coverage Diff @@
## master #23801 +/- ##
=======================================
Coverage 66.54% 66.54%
=======================================
Files 1941 1941
Lines 75280 75279 -1
Branches 8168 8168
=======================================
Hits 50093 50093
+ Misses 23098 23097 -1
Partials 2089 2089
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@rusackas, the rebase seems to have done the trick. |
SUMMARY
As already indicated in issue #22548 there is a TypeError when using the Handlebars visualization in the raw record mode. This seems to have been caused by adding the columns as an object instead of the expected array. I have simply taken the relevant code from the table plugin and replaced the invalid code with it.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
From #22548:
Local testing after the fix:
TESTING INSTRUCTIONS
raw records
query modeADDITIONAL INFORMATION