chore: fix params with marshmallow schema for Datasets #23829
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #23829 +/- ##
===========================================
- Coverage 67.99% 56.76% -11.24%
===========================================
Files 1937 1937
Lines 74934 74936 +2
Branches 8138 8138
===========================================
- Hits 50954 42540 -8414
- Misses 21895 30311 +8416
Partials 2085 2085
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 305 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
betodealmeida
approved these changes
Apr 26, 2023
| @@ -556,4 +556,4 @@ def test_import_parquet(mock_event_logger): | |||
|
|
|||
| with test_db.get_sqla_engine_with_context() as engine: | |||
| data = engine.execute(f"SELECT * from {PARQUET_UPLOAD_TABLE}").fetchall() | |||
| assert data == [("max", 3), ("bob", 4), ("john", 1), ("paul", 2)] | |||
| assert data == [("john", 1), ("paul", 2), ("max", 3), ("bob", 4)] | |||
There was a problem hiding this comment.
Suggested change
| assert data == [("john", 1), ("paul", 2), ("max", 3), ("bob", 4)] | |
| assert sorted(data) == [('bob', 4), ('john', 1), ('max', 3), ('paul', 2)] |
john-bodley
reviewed
Apr 27, 2023
| @@ -556,4 +556,4 @@ def test_import_parquet(mock_event_logger): | |||
|
|
|||
| with test_db.get_sqla_engine_with_context() as engine: | |||
| data = engine.execute(f"SELECT * from {PARQUET_UPLOAD_TABLE}").fetchall() | |||
| assert data == [("max", 3), ("bob", 4), ("john", 1), ("paul", 2)] | |||
| assert data == [("john", 1), ("paul", 2), ("max", 3), ("bob", 4)] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION