Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Loading state when cols for drill by are loading #23830

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

kgabryje
Copy link
Member

SUMMARY

When dataset is still loading, drill by option should be enabled but a loading spinner should be displayed until columns are available

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2023-04-26.at.16.58.39.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@lilykuang lilykuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #23830 (ffda33b) into master (40ae074) will increase coverage by 0.00%.
The diff coverage is 84.61%.

❗ Current head ffda33b differs from pull request most recent head 5efca21. Consider uploading reports for the commit 5efca21 to get more accurate results

@@           Coverage Diff           @@
##           master   #23830   +/-   ##
=======================================
  Coverage   67.99%   68.00%           
=======================================
  Files        1937     1937           
  Lines       74934    74937    +3     
  Branches     8138     8138           
=======================================
+ Hits        50954    50961    +7     
+ Misses      21895    21892    -3     
+ Partials     2085     2084    -1     
Flag Coverage Δ
javascript 54.29% <83.33%> (+<0.01%) ⬆️
mysql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/SqlLab/components/SaveDatasetModal/index.tsx 50.00% <0.00%> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js 66.33% <50.00%> (-0.17%) ⬇️
.../src/components/Chart/DrillBy/DrillByMenuItems.tsx 91.54% <100.00%> (+1.54%) ⬆️
...frontend/src/explore/actions/datasourcesActions.ts 100.00% <100.00%> (ø)
superset/views/core.py 75.11% <100.00%> (-0.21%) ⬇️

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kgabryje kgabryje merged commit 109f51b into apache:master Apr 26, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants