Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle comments in has_table_query #23882

Merged
merged 1 commit into from
May 1, 2023

Conversation

betodealmeida
Copy link
Member

SUMMARY

A small improvement to has_table_query, making it skip comments in the middle of the query.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Added tests.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

Merging #23882 (0c27a2b) into master (707c626) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0c27a2b differs from pull request most recent head 773bd9d. Consider uploading reports for the commit 773bd9d to get more accurate results

@@           Coverage Diff           @@
##           master   #23882   +/-   ##
=======================================
  Coverage   68.11%   68.11%           
=======================================
  Files        1938     1938           
  Lines       74973    74975    +2     
  Branches     8141     8141           
=======================================
+ Hits        51068    51070    +2     
  Misses      21826    21826           
  Partials     2079     2079           
Flag Coverage Δ
hive 53.01% <100.00%> (+<0.01%) ⬆️
mysql 78.80% <100.00%> (+<0.01%) ⬆️
postgres 78.88% <100.00%> (+<0.01%) ⬆️
presto 52.93% <100.00%> (+<0.01%) ⬆️
python 82.67% <100.00%> (+<0.01%) ⬆️
sqlite 77.39% <100.00%> (+<0.01%) ⬆️
unit 52.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/sql_parse.py 96.51% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@betodealmeida betodealmeida merged commit 2a1a061 into apache:master May 1, 2023
@dpgaspar dpgaspar added the 2.1.1 label May 10, 2023
@eschutho eschutho added the v2.1 label May 12, 2023
eschutho pushed a commit that referenced this pull request May 25, 2023
eschutho pushed a commit that referenced this pull request Jun 6, 2023
eschutho pushed a commit that referenced this pull request Jun 6, 2023
eschutho pushed a commit that referenced this pull request Jun 14, 2023
eschutho pushed a commit that referenced this pull request Jul 7, 2023
@mistercrunch mistercrunch added 🍒 2.1.1 🍒 2.1.2 🍒 2.1.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v2.1 🍒 2.1.1 🍒 2.1.2 🍒 2.1.3 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants