Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Viz migration adjustments - 1 #24341

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Makes adjustments to the viz migrations to fix problems found during tests.

  • Adjusts the Pivot Table migration to account only for the column totals instead of rows and columns given that the legacy chart didn't support row totals.
  • Adjusts the Pivot Table to sort the rows by descending values given that this was the original algorithm in the legacy version.
  • Adjusts the Dual Line migration to account for the GENERIC_CHART_AXES feature flag.
  • Adjusts migrations that contain a X-axis control to set the time grain as Day by default if none is provided

@jinghua-qa

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina requested a review from a team as a code owner June 9, 2023 13:31
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #24341 (254de28) into master (bdb8bbe) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

❗ Current head 254de28 differs from pull request most recent head 71c5610. Consider uploading reports for the commit 71c5610 to get more accurate results

@@            Coverage Diff             @@
##           master   #24341      +/-   ##
==========================================
- Coverage   69.08%   69.07%   -0.01%     
==========================================
  Files        1905     1905              
  Lines       74848    74851       +3     
  Branches     8108     8108              
==========================================
+ Hits        51705    51707       +2     
- Misses      21031    21032       +1     
  Partials     2112     2112              
Flag Coverage Δ
hive 53.67% <50.00%> (+<0.01%) ⬆️
mysql 79.30% <50.00%> (-0.01%) ⬇️
postgres 79.37% <50.00%> (-0.01%) ⬇️
presto 53.59% <50.00%> (+<0.01%) ⬆️
python 83.26% <75.00%> (-0.01%) ⬇️
sqlite 77.90% <50.00%> (-0.01%) ⬇️
unit 54.08% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/migrations/shared/migrate_viz/base.py 84.31% <50.00%> (-0.69%) ⬇️
...perset/migrations/shared/migrate_viz/processors.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina merged commit 4e47771 into apache:master Jun 9, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants