Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes #24391 (Problems with celery beat running with docker when the machine is rebooted suddenly) #24392

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

alvarolmedo
Copy link
Contributor

fix(celery beat): starts correctly after a reboot

SUMMARY

Removing pidfile before to start the the service is required to start the service correctly. Using docker not remove other (wrong) pidfile.

TESTING INSTRUCTIONS

  1. Run apache superset using docker compose:
    docker compose -f docker-compose-non-dev.yml up
  2. With containers running, reboot the machine.

ADDITIONAL INFORMATION

Fixes #24391

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@alvarolmedo alvarolmedo changed the title Fixes #24391: Problems with celery beat running with docker when the machine is rebooted suddenly fix: Fixes #24391 (Problems with celery beat running with docker when the machine is rebooted suddenly) Jun 14, 2023
@rusackas rusackas merged commit 19a9400 into apache:master Jun 14, 2023
@alvarolmedo alvarolmedo deleted the task/fix_celery_beat_bug branch June 15, 2023 07:50
@alvarolmedo
Copy link
Contributor Author

Thanks @craig-rueda @rusackas @john-bodley. :)

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docker-compose] Problems with Celery beat when the machine is rebooted suddenly
4 participants