Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sqllab): add extra_json on tabstate #24489

Merged

Conversation

justinpark
Copy link
Member

@justinpark justinpark commented Jun 22, 2023

SUMMARY

This commit includes the extra_json attribute on tabstate view in order to sync the latest async updated time used in SIP-93

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot_2023-06-22_at_1_16_02_PM

TESTING INSTRUCTIONS

check the bootstrap data in sqllab including extra_json

ADDITIONAL INFORMATION

  • Has associated issue: SIP-93
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #24489 (c1ebcdc) into master (51a34d7) will increase coverage by 0.07%.
The diff coverage is 32.14%.

❗ Current head c1ebcdc differs from pull request most recent head 4c3c03b. Consider uploading reports for the commit 4c3c03b to get more accurate results

@@            Coverage Diff             @@
##           master   #24489      +/-   ##
==========================================
+ Coverage   69.01%   69.08%   +0.07%     
==========================================
  Files        1901     1901              
  Lines       74034    74019      -15     
  Branches     8119     8116       -3     
==========================================
+ Hits        51091    51135      +44     
+ Misses      20835    20767      -68     
- Partials     2108     2117       +9     
Flag Coverage Δ
hive 53.89% <ø> (ø)
mysql 79.41% <ø> (ø)
postgres 79.50% <ø> (?)
presto 53.79% <ø> (ø)
python 83.49% <ø> (+0.07%) ⬆️
sqlite 78.00% <ø> (ø)
unit 54.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../packages/superset-ui-core/src/chart/types/Base.ts 100.00% <ø> (ø)
...rts/src/MixedTimeseries/EchartsMixedTimeseries.tsx 0.00% <ø> (ø)
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.00% <0.00%> (ø)
...chart-echarts/src/Timeseries/EchartsTimeseries.tsx 0.00% <0.00%> (ø)
...gin-chart-echarts/src/Timeseries/transformProps.ts 56.77% <0.00%> (ø)
superset/models/sql_lab.py 79.51% <ø> (ø)
...d/plugins/plugin-chart-echarts/src/utils/series.ts 85.48% <36.36%> (-1.88%) ⬇️
...lugin-chart-echarts/src/Timeseries/transformers.ts 56.20% <40.00%> (-0.75%) ⬇️
...et-frontend/src/components/Chart/ChartRenderer.jsx 50.58% <50.00%> (-0.02%) ⬇️
...es/superset-ui-core/src/chart/models/ChartProps.ts 100.00% <100.00%> (ø)

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justinpark You can use the extra property in ExtraJSONMixin which is part of TabState.

@justinpark justinpark force-pushed the chore--add-extra-json-on-tabstate branch from a70fb32 to 4c3c03b Compare June 23, 2023 16:36
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinpark justinpark merged commit e20b695 into apache:master Jun 23, 2023
sadpandajoe added a commit to preset-io/superset that referenced this pull request Jul 6, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants