Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(docker): pin the underlying debain base image #24497

Merged
merged 1 commit into from
Jun 23, 2023
Merged

build(docker): pin the underlying debain base image #24497

merged 1 commit into from
Jun 23, 2023

Conversation

boenshao
Copy link
Contributor

@boenshao boenshao commented Jun 23, 2023 •
edited
Loading

SUMMARY

The slim Python images are based on the latest Debian release.

Debian 12 Bookworm was released two weeks ago and I've seen some projects break because the APT packages they relied on are not available anymore.

As Superset does use apt-get during the build, it's better to pin the underlying Debian base image. This probably won't be an issue for a long time though...

TESTING INSTRUCTIONS

Manually build from the Dockerfile,

docker build --target lean -t superset .

In stdout, we should see that the image is built from 3.9-slim-bookworm,

Sending build context to Docker daemon    127MB
Step 1/31 : ARG PY_VER=3.9-slim-bookworm

And the build should finish without error.

Successfully tagged superset:latest

@craig-rueda craig-rueda merged commit e6f7c73 into apache:master Jun 23, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craig-rueda craig-rueda craig-rueda approved these changes

@villebro villebro Awaiting requested review from villebro villebro is a code owner

@geido geido Awaiting requested review from geido geido is a code owner

@eschutho eschutho Awaiting requested review from eschutho eschutho is a code owner

@rusackas rusackas Awaiting requested review from rusackas rusackas is a code owner

@betodealmeida betodealmeida Awaiting requested review from betodealmeida betodealmeida is a code owner

@nytai nytai Awaiting requested review from nytai nytai is a code owner

@mistercrunch mistercrunch Awaiting requested review from mistercrunch mistercrunch is a code owner

@john-bodley john-bodley Awaiting requested review from john-bodley john-bodley is a code owner

@kgabryje kgabryje Awaiting requested review from kgabryje kgabryje is a code owner

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boenshao @craig-rueda @mistercrunch