Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Un-revert enabling CSP by default #24543

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Jun 28, 2023

SUMMARY

This PR fixes a regression in #24262 that required reverting it (#24476). If TALISMAN_ENABLED is false, the csp_nonce function is undefined - here I introduced a macro that checks if the function is defined before calling it.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@kgabryje kgabryje added the risk:breaking-change Issues or PRs that will introduce breaking changes label Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #24543 (2223050) into master (66f59e5) will increase coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head 2223050 differs from pull request most recent head a2aed5e. Consider uploading reports for the commit a2aed5e to get more accurate results

@@            Coverage Diff             @@
##           master   #24543      +/-   ##
==========================================
+ Coverage   68.98%   69.08%   +0.10%     
==========================================
  Files        1906     1906              
  Lines       74114    74114              
  Branches     8155     8155              
==========================================
+ Hits        51124    51200      +76     
+ Misses      20871    20795      -76     
  Partials     2119     2119              
Flag Coverage Δ
hive 53.92% <100.00%> (?)
javascript 55.78% <ø> (-0.01%) ⬇️
mysql 79.40% <100.00%> (?)
postgres 79.48% <100.00%> (-0.01%) ⬇️
presto 53.82% <100.00%> (-0.01%) ⬇️
python 83.48% <100.00%> (+0.21%) ⬆️
sqlite 78.04% <100.00%> (-0.01%) ⬇️
unit 54.69% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../superset-ui-core/src/models/ExtensibleFunction.ts 100.00% <ø> (ø)
superset/config.py 92.00% <100.00%> (+0.02%) ⬆️
superset/initialization/__init__.py 91.04% <100.00%> (-0.31%) ⬇️

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kgabryje kgabryje merged commit 38df1a8 into apache:master Jun 29, 2023
eschutho added a commit to preset-io/superset that referenced this pull request Jul 7, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels risk:breaking-change Issues or PRs that will introduce breaking changes size/L 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants