Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Metric is truncated in tooltip #24555

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes a bug where the metric name is truncated when displayed in the tooltip. This creates a problem because the metric name might already be truncated in the control and the user wishes to see its full name. Now the tooltip will only truncate when it surpasses the max number of lines defined by the Tooltip component.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2023-06-29 at 14 29 27 Screenshot 2023-06-29 at 14 26 30

TESTING INSTRUCTIONS

Make sure metric names are displayed without truncation in the tooltip if under the Tooltip max lines limit.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina requested review from geido, kgabryje and justinpark and removed request for geido and kgabryje June 29, 2023 20:02
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #24555 (fb23241) into master (38df1a8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head fb23241 differs from pull request most recent head 52cbae9. Consider uploading reports for the commit 52cbae9 to get more accurate results

@@           Coverage Diff           @@
##           master   #24555   +/-   ##
=======================================
  Coverage   69.08%   69.08%           
=======================================
  Files        1906     1906           
  Lines       74114    74119    +5     
  Branches     8155     8155           
=======================================
+ Hits        51200    51205    +5     
  Misses      20795    20795           
  Partials     2119     2119           
Flag Coverage Δ
javascript 55.78% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-ui-chart-controls/src/components/labelUtils.tsx 100.00% <ø> (ø)
superset-frontend/src/components/Tooltip/index.tsx 100.00% <ø> (ø)
...e/components/controls/MetricControl/AdhocMetric.js 95.55% <100.00%> (-0.10%) ⬇️
superset/config.py 92.00% <100.00%> (ø)
superset/views/base.py 73.33% <100.00%> (+0.54%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina merged commit 5bdb774 into apache:master Jun 30, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants