Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove obsolete legacy visualizations #24692

Conversation

john-bodley
Copy link
Member

SUMMARY

This is a rehash of #24675 without the deprecation of the TableViz as sadly the legacy visualization is deeply entangled with the annotation layers. Specifically this PR removes the following obsolete chart types:

  • BigNumberViz
  • BigNumberTotalViz

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #24692 (acc08fa) into master (462418b) will decrease coverage by 0.08%.
The diff coverage is 91.12%.

❗ Current head acc08fa differs from pull request most recent head 090ced2. Consider uploading reports for the commit 090ced2 to get more accurate results

@@            Coverage Diff             @@
##           master   #24692      +/-   ##
==========================================
- Coverage   69.03%   68.96%   -0.08%     
==========================================
  Files        1908     1901       -7     
  Lines       74210    73965     -245     
  Branches     8186     8182       -4     
==========================================
- Hits        51232    51007     -225     
+ Misses      20857    20837      -20     
  Partials     2121     2121              
Flag Coverage Δ
hive 54.13% <20.49%> (+0.01%) ⬆️
mysql 79.34% <91.80%> (-0.09%) ⬇️
postgres 79.42% <91.80%> (-0.09%) ⬇️
presto 54.03% <20.49%> (+0.01%) ⬆️
python 83.44% <91.80%> (-0.06%) ⬇️
sqlite 78.01% <80.32%> (-0.07%) ⬇️
unit 54.85% <20.49%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/reports/commands/exceptions.py 98.33% <ø> (-0.03%) ⬇️
superset/viz.py 66.21% <ø> (-0.70%) ⬇️
.../plugin-chart-pivot-table/src/plugin/buildQuery.ts 73.33% <50.00%> (+1.90%) ⬆️
superset/annotation_layers/api.py 86.20% <50.00%> (-0.12%) ⬇️
superset/css_templates/commands/delete.py 87.50% <50.00%> (ø)
superset/queries/saved_queries/commands/delete.py 87.50% <50.00%> (ø)
superset/row_level_security/commands/delete.py 86.36% <50.00%> (ø)
superset/annotation_layers/annotations/api.py 89.23% <66.66%> (-0.09%) ⬇️
superset/css_templates/api.py 95.74% <66.66%> (ø)
superset/datasets/api.py 88.62% <66.66%> (-0.04%) ⬇️
... and 20 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-bodley
Copy link
Member Author

Closing in favor of #24694.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants