fix(datasets): give possibility to add dataset with slashes in name

[Always-prog]

SUMMARY

Give possibility to users to add datasets which contains slashes in a table name

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

2023-07-25_15-24-31.mp4

After

2023-07-25_15-28-11.mp4

TESTING INSTRUCTIONS

1. Go to "*/dataset/add/" URL, or push "+DATASET" button.
2. Choose database and schema.
3. Choose a table with "/" symbol in name
4. See error

ADDITIONAL INFORMATION

• Has associated issue: 23540
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #24796 (bb0263e) into master (5bb8e0d) will not change coverage.
The diff coverage is 100.00%.

❗ Current head bb0263e differs from pull request most recent head 4119ee6. Consider uploading reports for the commit 4119ee6 to get more accurate results

@@           Coverage Diff           @@
##           master   #24796   +/-   ##
=======================================
  Coverage   68.99%   68.99%           
=======================================
  Files        1903     1903           
  Lines       74072    74072           
  Branches     8193     8193           
=======================================
  Hits        51104    51104           
  Misses      20847    20847           
  Partials     2121     2121           

Flag	Coverage Δ
hive	54.13% <100.00%> (ø)
mysql	79.21% <100.00%> (ø)
postgres	79.31% <100.00%> (ø)
presto	54.03% <100.00%> (ø)
python	83.36% <100.00%> (ø)
sqlite	77.88% <100.00%> (ø)
unit	54.99% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
superset/databases/api.py	89.90% <100.00%> (ø)
superset/views/core.py	69.46% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[michael-s-molina]

Thank for the PR @Always-prog. Could you add a test?

[Always-prog]

@michael-s-molina Yeah, I can. I'll add it.

[michael-s-molina]

@Always-prog If you do a quick search for <table_name> you'll see that there are other endpoints that need to be modified.

@dpgaspar Is there any concern with this change?

[Always-prog]

@michael-s-molina I added a test for the slash in the table name and updated the table_name parameter type to path in all endpoints.

[michael-s-molina]

Here's the list of places that have <table_name>:

superset/databases/api.py::table_metadata
superset/databases/api.py::table_extra_metadata
superset/databases/api.py::select_star
superset/views/core.py::fetch_datasource_metadata
superset/db_engine_specs/presto.py::TABLE_DOES_NOT_EXIST_REGEX

[Always-prog]

@michael-s-molina I added path type to the all endpoints in your list excluding presto.py file because it contains just regex functions with <table_name>, it isn't endpoint.

[Always-prog]

@michael-s-molina Hello! Can I get code review?

[michael-s-molina]

It seems MySQL and SQLite support table names with slashes but you need to escape them.

[Always-prog]

@michael-s-molina I added MySQL and SQLite to the test case, but why is there an error while migrating? I haven't changed any migrations.

[michael-s-molina]

@michael-s-molina I added MySQL and SQLite to the test case, but why is there an error while migrating? I haven't changed any migrations.

It seems the error was fixed by #24832. You need to rebase your PR.

[Always-prog]

@michael-s-molina Rebased

[michael-s-molina]

LGTM. Thank you for the fix @Always-prog!