Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calls to _get_sqla_engine #24953

Merged
merged 2 commits into from
Aug 11, 2023

Fix inspector

9412cf8
Select commit
Loading
Failed to load commit list.
Merged

fix: calls to _get_sqla_engine #24953

Fix inspector
9412cf8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 11, 2023 in 1s

69.03% (+0.00%) compared to ce65a3b

View this Pull Request on Codecov

69.03% (+0.00%) compared to ce65a3b

Details

Codecov Report

Merging #24953 (9412cf8) into master (ce65a3b) will increase coverage by 0.00%.
The diff coverage is 83.33%.

@@           Coverage Diff           @@
##           master   #24953   +/-   ##
=======================================
  Coverage   69.03%   69.03%           
=======================================
  Files        1905     1905           
  Lines       74136    74134    -2     
  Branches     8212     8212           
=======================================
  Hits        51181    51181           
+ Misses      20832    20830    -2     
  Partials     2123     2123           
Files Changed Coverage Δ
superset/db_engine_specs/trino.py 83.06% <0.00%> (-0.68%) ⬇️
superset/models/core.py 90.16% <100.00%> (-0.07%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more