Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Downgrades Prophet to 1.1.1 and Holidays to 0.23 #25017

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Aug 17, 2023

SUMMARY

#24129 bumped Prophet to 1.1.4 but there's a nasty bug affecting all versions following 1.1.1. This PR downgrades Prophet to 1.1.1 and pins the version in setup.py. We can relax the version constraint once that bug is fixed.

This PR also reverts the holidays bump given that version 0.28 is incompatible with prophet 1.1.1 even with a declared dependency of holidays>=0.14.2. I tried using version 0.28 but it broke CI.

TESTING INSTRUCTIONS

CI should be sufficient.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina changed the title fix: Downgrade Prophet to 1.1.1 fix: Downgrade Prophet to 1.1.1 and Holidays to 0.23 Aug 17, 2023
@michael-s-molina michael-s-molina changed the title fix: Downgrade Prophet to 1.1.1 and Holidays to 0.23 fix: Downgrades Prophet to 1.1.1 and Holidays to 0.23 Aug 17, 2023
@michael-s-molina michael-s-molina merged commit 62cbc0c into apache:master Aug 17, 2023
32 checks passed
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Aug 17, 2023
@michael-s-molina michael-s-molina mentioned this pull request Aug 21, 2023
9 tasks
@mtthsbrr
Copy link

mtthsbrr commented Sep 5, 2023

For me the combination prophet 1.1.4 and holidays 0.32 is working when installing it inside of a running superset 2.1.0 container.

@mdeshmu
Copy link
Contributor

mdeshmu commented Oct 8, 2023

@mtthsbrr do you mean you are not facing this bug with the above combination?

@mdeshmu mdeshmu mentioned this pull request Oct 8, 2023
9 tasks
@mtthsbrr
Copy link

mtthsbrr commented Oct 9, 2023

@mtthsbrr do you mean you are not facing this bug with the above combination?

Right - no issues for me. At least when installing it inside the already running container. Not sure if this makes any difference though. The pip freeze outputs holidays==0.32 and prophet==1.1.4 as part of the list.

Maybe it's worth mentioning that I'm actually running a latest-dev container built with a createdAT timestamp "2023-07-20T12:20:53Z".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants