Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(command): Organize Commands according to SIP-92 #25850

Merged

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Nov 3, 2023

SUMMARY

This PR is one of many to related to SIP-92 Proposal for restructuring the Python code base. Specifically it organizes all the Commands under the superset/commands subfolder. The naming convention adheres to #24331, though upon further inspection thedaos/annotation.py file was renamed to daos/annotation_layer.py given that Annotation Layer is actually the umbrella construct.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

  • Has associated issue: [SIP-92] Proposal for restructuring the Python code base #20630
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley force-pushed the john-bodley--sip-92-commands branch 4 times, most recently from 1701917 to f774fa5 Compare November 3, 2023 04:51
@john-bodley john-bodley marked this pull request as ready for review November 3, 2023 05:16
@john-bodley john-bodley force-pushed the john-bodley--sip-92-commands branch 5 times, most recently from 86d25ae to edda57b Compare November 22, 2023 01:12
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (6359086) 58.92% compared to head (775da08) 69.09%.
Report is 3 commits behind head on master.

Files Patch % Lines
superset/commands/importers/v1/examples.py 0.00% 11 Missing ⚠️
superset/cli/importexport.py 85.71% 1 Missing ⚠️
superset/common/query_context_processor.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #25850       +/-   ##
===========================================
+ Coverage   58.92%   69.09%   +10.17%     
===========================================
  Files        1940     1940               
  Lines       75867    75867               
  Branches     8444     8444               
===========================================
+ Hits        44706    52423     +7717     
+ Misses      28985    21268     -7717     
  Partials     2176     2176               
Flag Coverage Δ
hive 53.68% <93.90%> (ø)
mysql 78.16% <97.26%> (?)
postgres 78.25% <97.26%> (?)
presto 53.63% <93.90%> (ø)
python 82.95% <97.26%> (+21.15%) ⬆️
sqlite 76.91% <97.26%> (?)
unit 55.79% <91.38%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@john-bodley john-bodley changed the title chore(dao): Organize Commands according to SIP-92 chore(command): Organize Commands according to SIP-92 Nov 22, 2023
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit 07bcfa9 into apache:master Nov 22, 2023
33 checks passed
@john-bodley john-bodley deleted the john-bodley--sip-92-commands branch November 22, 2023 21:05
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants