Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update cryptography to >= 42.0.5 #27249

Closed
wants to merge 3 commits into from
Closed

Conversation

nigzak
Copy link
Contributor

@nigzak nigzak commented Feb 26, 2024

SUMMARY

cryptography has some high CVE findings which are fixed with newer version.
To fix this the min-version in setup.py should be updated to latest version (42.0.5)

CVE-2024-26130⁠ (CVSS 7.5)
CVE-2023-50782⁠ (CVSS 7.5)
CVE-2024-0727⁠ (CVSS 5.5)
CVE-2023-49083⁠ (CVSS 5.9)
(and some low)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TESTING INSTRUCTIONS

Open final build software and check that cryptography 41.0.5 (or newer) is inside

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@nigzak nigzak reopened this Feb 26, 2024
@pull-request-size pull-request-size bot added size/M and removed size/S labels Feb 26, 2024
@nigzak nigzak changed the title chore: update cryptography to >= 41.0.5 chore: update cryptography to >= 42.0.5 Feb 26, 2024
@@ -81,7 +81,7 @@ def get_git_sha() -> str:
"croniter>=0.3.28",
"cron-descriptor",
# snowflake-connector-python as of 3.7.0 doesn't support >=42.* therefore lowering the min to 41.0.2
"cryptography>=41.0.2, <43.0.0",
"cryptography>=42.0.5, <43.0.0",
Copy link
Member

@dpgaspar dpgaspar Feb 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to keep this at 41.0.2 because there are extra dependencies that colide with it. use base.in instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean to roll back the changes and only add the 42.0.5 version in base.in instead for now - right?

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.57%. Comparing base (1d571ec) to head (44c9eb9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27249      +/-   ##
==========================================
- Coverage   69.69%   69.57%   -0.12%     
==========================================
  Files        1908     1908              
  Lines       74530    74530              
  Branches     8309     8309              
==========================================
- Hits        51942    51856      -86     
- Misses      20535    20621      +86     
  Partials     2053     2053              
Flag Coverage Δ
hive ?
mysql 77.97% <ø> (-0.03%) ⬇️
postgres 78.10% <ø> (ø)
presto ?
python 82.88% <ø> (-0.24%) ⬇️
sqlite 77.61% <ø> (ø)
unit 56.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas rusackas added the hold! On hold label Feb 26, 2024
@dpgaspar
Copy link
Member

This is being done here: #27281 snowflake just updated and released.
After 27281 is merged I think we can close this one

@sadpandajoe
Copy link
Member

This is being done here: #27281 snowflake just updated and released. After 27281 is merged I think we can close this one

I just merged #27281 so you can rebase and bump if you need to.

@nigzak
Copy link
Contributor Author

nigzak commented Mar 1, 2024

cryptography 42.0.4 also has no findings (CVE scan) and it is already in master
=> closing this pull request now because it is outdated

@nigzak nigzak closed this Mar 1, 2024
@nigzak nigzak deleted the crypto branch March 1, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants