Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): docker builds don't work from remote forks #27282

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Feb 28, 2024

SUMMARY

Fix issues relate to multi-platform builds not working with --load.

Lots of intricacies around multi-platform builds somehow (doesn't work on OSx, doesn't work with --load, and somehow can't --push from remote forks, ...)

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpgaspar dpgaspar merged commit 0383bed into master Feb 28, 2024
23 of 24 checks passed
@rusackas rusackas deleted the fix_docker_again2 branch February 28, 2024 22:23
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants