Hack around the "last migration doesn't stamp" Alembic bug #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
test_migration
branch
from
a20e0b5
to
e1d066c
Compare
This makes MySQL, Sqlite and Postgres work with a special hard coded rule. I'm hoping Alembic fixes the root cause eventually.
mistercrunch
force-pushed
the
test_migration
branch
from
e1d066c
to
0378841
Compare
|
Commit cite Postgresql but you are not doing anything specific for it. |
|
Postgres was working with the current default setup. Though I might want to run the |
|
@mistercrunch |
|
A'ight done, I referenced the new location of the DB as well |
zhaoyongjie
added a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
* feat: add dropGroupByControl * control rename to DndColumnSelectControl * add DND feature flag * wip * fix lint * duplicate dnd control
zhaoyongjie
added a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
* feat: add dropGroupByControl * control rename to DndColumnSelectControl * add DND feature flag * wip * fix lint * duplicate dnd control
zhaoyongjie
added a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
* feat: add dropGroupByControl * control rename to DndColumnSelectControl * add DND feature flag * wip * fix lint * duplicate dnd control
zhaoyongjie
added a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
* feat: add dropGroupByControl * control rename to DndColumnSelectControl * add DND feature flag * wip * fix lint * duplicate dnd control
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes MySQL, Sqlite and Postgres work with a special hard coded
rule. I'm hoping Alembic fixes the root cause eventually.
@bkyryliuk