Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for fill fragmentation in rangeArea plots with nulls in data #4366

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

rosco54
Copy link
Contributor

@rosco54 rosco54 commented Mar 30, 2024

There is still an issue with the pathTo and pathFrom path arrays used in animations not handling null data. This causes some glitching during animation.

This fix only affects smooth curves. Will look at straight line plots next.

Fixes #3525 (mostly)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

There is still an issue with the pathTo
and pathFrom path arrays used in animations not handling null data.
This causes some glitching during animation.
@junedchhipa junedchhipa merged commit bdef9a8 into apexcharts:main Mar 30, 2024
@rosco54
Copy link
Contributor Author

rosco54 commented Mar 30, 2024 via email

@rosco54 rosco54 deleted the RangeArea_with_nulls branch May 5, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RangeArea with null value removes fill color
2 participants