Fix(graphql)(mercure): Use public URL for subscription URI creation if it is available #6514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required when publishing and reading host names are not the same, ex: docker environment ("mercure" vs "localhost:port" between server side and client side), having different publishing URL and public access url's, etc.
Mercure itself and Mercure bundle have been supporting this for a while.
psihius
changed the title
psihius
changed the title
dunglas
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required when publishing and reading host names are not the same, ex: docker environment ("mercure" vs "localhost:port" between server side and client side), having different publishing URL and public access url's, etc. Mercure itself and Mercure bundle have been supporting this for a while.