Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!(state): precise format on content-location #6627

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix!(state): precise format on content-location #6627

merged 1 commit into from
Sep 19, 2024

Conversation

soyuka
Copy link
Member

@soyuka soyuka commented Sep 19, 2024 •
edited
Loading

fixes #6625

@soyuka soyuka force-pushed the fix/6625 branch 2 times, most recently from 204ed2a to f8c0c6a Compare September 19, 2024 14:58
@dunglas
Copy link
Member

dunglas commented Sep 19, 2024

Shouldn't we also append query parameters?

@soyuka soyuka merged commit eb80a1a into api-platform:4.0 Sep 19, 2024
40 of 59 checks passed
@darkweak
Copy link
Contributor

@dunglas the query parameters don't influence the Content-Location IMHO.

@dunglas
Copy link
Member

dunglas commented Sep 19, 2024 •
edited
Loading

query parameters are part of the URI, so they do IMHO. /collection?page=1 is not the same resource as /collection?page=42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soyuka @dunglas @darkweak