fix: prevents recomputing normalizationcontext #6700
+99
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhelias
force-pushed
the
prevents-recomputing-normalizationcontext
branch
from
9edd9c5
to
a72505e
Compare
maxhelias
force-pushed
the
prevents-recomputing-normalizationcontext
branch
from
a72505e
to
413dd77
Compare
soyuka
reviewed
Oct 7, 2024
| 'resource_class' => $class, | ||
| 'operation' => $operation, | ||
| ]); | ||
| if (null === ($serializerContext = $request->attributes->get('_api_normalization_context'))) { |
There was a problem hiding this comment.
shouldn't we move the responsibility of this to the SerializerContextBuilder directly? It'd avoid duplicating this condition. I'd also do the set there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check and use the previously computed context