find_motifs_iter: report best match
#44
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleclearmind
changed the title
find_motifs_iter: report best match
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of no results, it's still useful to have something to report to the user.
Our specific use case is the following: we use grandiso in our test framework (which involves graphs). In case of test failure (no graph match), we currently get no information and the developer needs to figure out on its own the problem.
With this patch, we can provide the developers with a pair of colored graphs reporting the best match we found before giving up, which usually enables the developer to rapidly highlight the problem by looking at uncolored nodes.
It's not perfect and I'm open to feedback on the metric to establish the best match and to more Pythonic ways to report the best match (currently it uses a one-element
listas an "out" parameter).Note the leftmost white node, it's the source of the mismatch: