Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Subtree bug #38

Merged
merged 1 commit into from
Sep 19, 2023
Merged

fix: Subtree bug #38

merged 1 commit into from
Sep 19, 2023

Conversation

BobaFetters
Copy link
Member

@BobaFetters BobaFetters commented Sep 19, 2023

-Adding the customized git subtree script to use for CI that included the subtree bugfix

Discovered a bug in the git subtree functionality where while performing a split of subtree 'A', if split commits for another subtree ('B' for example) are part of the commits to process since the last split/rejoin, then it causes the split processing to have to traverse the entire history of the second subtree 'B', even though those commits are irrelevant to the split being processed for subtree 'A'.

I implemented a fix in the git-subtree.sh script and have placed a custom version of that script in our repository temporarily for us to use for our workflow until the fix can be merged and released as part of an official git release, at which point these scripts can be removed and we will switch back to using the official release version of the subtree functionality.

-Adding the customized git subtree script to use for CI that included the subtree bugfix
Copy link
Contributor

@AnthonyMDev AnthonyMDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! :) Thank you Zach!!

@@ -0,0 +1,357 @@
# This shell scriplet is meant to be included by other shell scripts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a script you got from somewhere else? We just need to make sure we are checking the LICENSE and it's okay to reuse this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its part of git and required for the subtree script to run correctly

@BobaFetters BobaFetters merged commit 5d29db0 into project-breakup Sep 19, 2023
12 checks passed
@BobaFetters BobaFetters deleted the fix/subtree-bug branch September 19, 2023 20:58
BobaFetters added a commit that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants