fix: do nothing for an empty array in w3c actions #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it make more sense to apply it after #309 is merged? |
|
sounds good. Yea, I'll take a look at the key actions first |
|
@mykola-mokhnach can you review this? I have updated all. |
mykola-mokhnach
approved these changes
Jul 20, 2024
| @@ -792,14 +792,6 @@ @implementation FBW3CActionsSynthesizer | |||
| }); | |||
|
|
|||
| NSArray<NSDictionary<NSString *, id> *> *actionItems = [actionDescription objectForKey:FB_KEY_ACTIONS]; | |||
| if (nil == actionItems || 0 == actionItems.count) { | |||
There was a problem hiding this comment.
should we short circuit here if this condition is true?
There was a problem hiding this comment.
Sure, let me keep them in case we use them in another place without guard in this PR
| @@ -873,14 +865,6 @@ @implementation FBW3CActionsSynthesizer | |||
| } | |||
|
|
|||
| NSArray<NSDictionary<NSString *, id> *> *actionItems = [actionDescription objectForKey:FB_KEY_ACTIONS]; | |||
| if (nil == actionItems || 0 == actionItems.count) { | |||
KazuCocoa
commented
Jul 21, 2024
| @@ -874,7 +874,7 @@ @implementation FBW3CActionsSynthesizer | |||
|
|
|||
| NSArray<NSDictionary<NSString *, id> *> *actionItems = [actionDescription objectForKey:FB_KEY_ACTIONS]; | |||
| if (nil == actionItems || 0 == actionItems.count) { | |||
| NSString *description = [NSString stringWithFormat:@"It is mandatory to have at least one gesture item defined for each action. Action with id '%@' contains none", actionId]; | |||
| NSString *description = [NSString stringWithFormat:@"It is mandatory to have at least one gesture item defined for each action. Action with id '%@' contains none", actionId]; | |||
There was a problem hiding this comment.
Here is to make 4 spaces from 3
github-actions bot
pushed a commit
that referenced
this pull request
Jul 21, 2024
## [1.18.2](v1.18.1...v1.18.2) (2024-07-21) ### Bug Fixes * do nothing for an empty array in w3c actions ([#308](#308)) ([a1aa636](a1aa636))
|
🎉 This issue has been resolved in version 1.18.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appium/WebDriverAgent#919 for mac2 driver