fix: Avoid using getSession call for capability values retrieval #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mykola-mokhnach
changed the title
mykola-mokhnach
changed the title
mykola-mokhnach
changed the title
mykola-mokhnach
force-pushed
the
get_session
branch
from
dab1de1
to
5330470
Compare
|
The error in e2e tests is a CI flakiness issue |
Yeah, I did notice in master. Will fix it asap. |
This was referenced Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
W3C protocol does not contain getSession API in its spec, which means all calls to
HasSessionDetailsinterface methods will end up withno such methoderror. As a result, I have replaced all the "static" calls with simple capabilities extraction and the "dynamic" call uses the fact that none of native mobile drivers support javascript execution, - this only works in browser context.Types of changes
Details
See https://github.com/appium/appium/issues/13124#issuecomment-524850823