feat: add support for logCustomEvent command #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlipps
force-pushed
the
jlipps-custom-log
branch
2 times, most recently
from
4e47236
to
8052484
Compare
|
The Azure failure is a timeout of some kind and it seems to have existed since before this PR; not sure what to do about that. |
src/main/java/io/appium/java_client/serverevents/CommandEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/serverevents/CommandEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/serverevents/ServerEvent.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/serverevents/ServerEvents.java
Outdated
Show resolved
Hide resolved
jlipps
force-pushed
the
jlipps-custom-log
branch
from
8052484
to
760df68
Compare
src/main/java/io/appium/java_client/serverevents/CommandEvent.java
Outdated
Show resolved
Hide resolved
jlipps
force-pushed
the
jlipps-custom-log
branch
from
760df68
to
5c22d6c
Compare
mykola-mokhnach
approved these changes
Nov 6, 2019
|
|
||
| public final List<CommandEvent> commands; | ||
| public final List<TimedEvent> events; | ||
| public final String jsonData; |
There was a problem hiding this comment.
should it be string or JSONObject?
There was a problem hiding this comment.
string, because its only purpose is to write out to disk.
SrinivasanTarget
approved these changes
Nov 6, 2019
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on appium/appium-base-driver#364
(I couldn't get tests to run due to some Class Not Found error that seems unrelated.)