Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use lower case for Windows platform key in ElementMap #1421

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

valfirst
Copy link
Collaborator

Change list

Fixes #965
Fixes #774
Fixes #1247

Types of changes

What types of changes are you proposing/introducing to Java client?

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@valfirst valfirst changed the title Fix the key for Windows platform in ElementMap fix: Use lower case for Windows platform key in ElementMap Dec 15, 2020
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should make no difference for Appium, since the comparison is anyway case-insensitive.

@valfirst
Copy link
Collaborator Author

@mykola-mokhnach I believe the problem comes from these lines where the keys to find are converted to lower case:

ElementMap element = Optional.ofNullable(mobileElementMap.get(
String.valueOf(platform).toLowerCase().trim()))
.orElseGet(() -> mobileElementMap
.get(String.valueOf(automation).toLowerCase().trim()));

@valfirst valfirst force-pushed the fix-965 branch 2 times, most recently from 95b8411 to 2c8d7df Compare December 18, 2020 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants