Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Deprecate custom event listener implementation and default to the one provided by Selenium4 #1541

Merged
merged 3 commits into from
Oct 24, 2021

Conversation

mykola-mokhnach
Copy link
Contributor

Change list

Getting rid of the custom stuff could help us to get rid of spring and aspectj dependencies and is going to simplify the client a lot and make it much "thinner". I did not remove the obsolete classes yet, but just marked them as deprecated.

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Classes that implement this interface are intended to be used with EventFiringDecorator.
This interface provides empty default implementation for all methods that do nothing.
You could easily extend that interface to add more methods that you'd like to listen to.
The strategy to add new/custom event listeners is the following. Let say there is a public setOrientation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The strategy to add new/custom event listeners is the following. Let say there is a public setOrientation
The strategy to add new/custom event listeners is the following. Let say there is a public `setOrientation`

@mykola-mokhnach mykola-mokhnach merged commit 1a8ff99 into appium:master Oct 24, 2021
@mykola-mokhnach mykola-mokhnach deleted the depr_event_firing branch October 24, 2021 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants