Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: switch to javac compiler #1556

Merged
merged 3 commits into from
Oct 27, 2021
Merged

chore: switch to javac compiler #1556

merged 3 commits into from
Oct 27, 2021

Conversation

mykola-mokhnach
Copy link
Contributor

@mykola-mokhnach mykola-mokhnach commented Oct 27, 2021 •
edited
Loading

Change list

There is no need to use ECJ anymore after we get rid from selenium package override

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

valfirst
valfirst reviewed Oct 27, 2021
View reviewed changes
build.gradle Show resolved Hide resolved
@mykola-mokhnach mykola-mokhnach merged commit da8fde2 into appium:master Oct 27, 2021
@mykola-mokhnach mykola-mokhnach deleted the javac_switch branch October 27, 2021 16:03
MrGizzle
MrGizzle reviewed Dec 28, 2021
View reviewed changes
Copy link

@MrGizzle MrGizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrGizzle MrGizzle MrGizzle left review comments

@valfirst valfirst valfirst approved these changes

@SrinivasanTarget SrinivasanTarget SrinivasanTarget approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mykola-mokhnach @valfirst @SrinivasanTarget @MrGizzle