Use java.time.Duration to represent time deltas instead of elementary types #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TikhomirovSergey
suggested changes
Apr 3, 2017
| import java.time.Duration; | ||
|
|
||
| public class DurationUtils { | ||
| public static int durationToMillis(Duration duration) { |
There was a problem hiding this comment.
@mykola-mokhnach
Maybe it is more senseful to use this method instead of the util
Duration duration;
....
duration.toMillis();There was a problem hiding this comment.
fixed. I dunno why I skipped the fact, that Duration class already has such method %)
|
@mykola-mokhnach Hi. Sorry for the delaying. I am usually busy now. @SrinivasanTarget What is your opinion? |
mykola-mokhnach
force-pushed
the
duration_arg
branch
from
bec1d6e
to
d1026e9
Compare
|
@TikhomirovSergey np, thanks for the review. I'd be happy if someone could also add comments to the other one at #595 |
SrinivasanTarget
approved these changes
Apr 4, 2017
TikhomirovSergey
approved these changes
Apr 4, 2017
|
@mykola-mokhnach Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Replace timeout/duration arguments where possible with java.time.Duration type, which has been introduced in Java 8.. This gives us better control over time conversion and helps to avoid time unit conversion issues in general.
All the existing methods, that have replacements, were marked as deprecated.
Types of changes