Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#718 FIX #722

Merged
merged 2 commits into from
Sep 8, 2017
Merged

#718 FIX #722

merged 2 commits into from
Sep 8, 2017

Conversation

TikhomirovSergey
Copy link
Contributor

@TikhomirovSergey TikhomirovSergey commented Sep 7, 2017

Change list

#718 FIX

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

There was the dependency conflict inside java_clint. As it was resolved by exclusion of malformed artefacts, I think we could return selenium dependency version to its normal form with force compilation. I think that it is the case when the simple solution is enough.

@@ -54,7 +54,7 @@ compileJava {
]
}

ext.seleniumVersion = '[3.5.3,3.5.3]'
ext.seleniumVersion = '3.5.3'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a comment here about version number format restriction

@TikhomirovSergey TikhomirovSergey merged commit c9b80c8 into appium:master Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants