Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clipboard handlers #855

Merged
merged 3 commits into from
Apr 10, 2018
Merged

Add clipboard handlers #855

merged 3 commits into from
Apr 10, 2018

Conversation

mykola-mokhnach
Copy link
Contributor

Change list

this adds possibility to set and get clipboard content for Android and iOS

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@mykola-mokhnach
Copy link
Contributor Author

@KazuCocoa FYI

SrinivasanTarget
SrinivasanTarget requested changes Mar 28, 2018
View reviewed changes
src/main/java/io/appium/java_client/ios/HasIOSClipboard.java
*/
default void setClipboardUrl(URL url) {
setClipboard(ClipboardContentType.URL, Base64
.getEncoder()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getURLEncoder() & getURLDecoder() should be good than basic encoding/decoding as it is not URL safe. Also for text encoding, i would recommend to use MIME encoding over basic encoding. what say @mykola-mokhnach ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is not the case for Apple's NSData class, since it requires the data to be always padded: https://stackoverflow.com/questions/21406482/nsdata-wont-accept-valid-base64-encoded-string

@SrinivasanTarget
Copy link
Member

waiting for drivers to get published. will play around after that.

@appium appium deleted a comment Mar 28, 2018
@mykola-mokhnach mykola-mokhnach mentioned this pull request Mar 29, 2018
Merged
@TikhomirovSergey
Copy link
Contributor

@mykola-mokhnach Will review today

SrinivasanTarget
SrinivasanTarget approved these changes Apr 8, 2018
View reviewed changes
Copy link
Member

@SrinivasanTarget SrinivasanTarget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well on both iOS and android.

@SrinivasanTarget
Copy link
Member

appium/WebDriverAgent#70

@SrinivasanTarget SrinivasanTarget merged commit 2f60e64 into appium:master Apr 10, 2018
@mykola-mokhnach mykola-mokhnach deleted the clipboard branch April 11, 2018 04:58
SrinivasanTarget pushed a commit that referenced this pull request Apr 18, 2018
@TikhomirovSergey @SrinivasanTarget
Addition to #846 and #855: (#869)
a542fee 
* Addition to #846 and #855:
- OkHttpClient instead of ApacheHttpClient
- fix of java.lang.IllegalArgumentException: Input byte array has incorrect ending byte at...

* Addition to #846 and #855:
- using of mime encoder/decoder
@mykola-mokhnach mykola-mokhnach mentioned this pull request Apr 20, 2018
Closed
@mykola-mokhnach mykola-mokhnach mentioned this pull request Aug 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SrinivasanTarget SrinivasanTarget SrinivasanTarget approved these changes

@TikhomirovSergey TikhomirovSergey Awaiting requested review from TikhomirovSergey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mykola-mokhnach @SrinivasanTarget @TikhomirovSergey