Add battery information accessors #882
Conversation
|
@KazuCocoa FYI |
| public BatteryStatus getStatus() { | ||
| final int status = ((Long) getInput().get("status")).intValue(); | ||
| switch (status) { | ||
| case 2: |
There was a problem hiding this comment.
I think it would be better to move these magic numbers to enum.
There was a problem hiding this comment.
these are used only once in this particular place. Creating a separate enum for them would be an overkill.
|
@mykola-mokhnach There is the conflict. Could you resolve it? |
… into battery # Conflicts: # src/main/java/io/appium/java_client/ios/IOSDriver.java
|
Resolved |
|
@mykola-mokhnach Going to run Android tests today. |
|
@TikhomirovSergey Android is still not merged. There are problems with server publishing. I'll add a comment when it's done |
|
@mykola-mokhnach Ok. Maybe there is sense to publish 6.0.0 without this change? How about 6.0.1? |
|
@TikhomirovSergey No problems |
|
The Pr for uia2 driver has been merged, so this PR can be merged as well. |
|
@TikhomirovSergey We are good to release 6.0.0 with this now :) |
Change list
Depends on
appium/appium-uiautomator2-driver#164
appium/appium-xcuitest-driver#661
Types of changes