Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added multipart app/json support #28911

Merged
merged 8 commits into from
Nov 23, 2023
Merged

feat: added multipart app/json support #28911

merged 8 commits into from
Nov 23, 2023

Conversation

sondermanish
Copy link
Contributor

@sondermanish sondermanish commented Nov 16, 2023 •
edited by sumitsum
Loading

Description

Added multi part form data application/json support

PR fixes following issue(s)

Fixes #28419

Type of change

  • Feature Improvement

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

  • Manual
  • JUnit

@github-actions github-actions bot added Query & JS Pod Issues related to the query & JS Pod Community Reported issues reported by community members Enhancement New feature or request Integrations Product Issues related to a specific integration REST API plugin REST API plugin related issues labels Nov 16, 2023
@sondermanish
Copy link
Contributor Author

/ok-to-test

@sondermanish
Copy link
Contributor Author

/build-deploy-preview skip-tests=true

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6901876988.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 28911.

@github-actions GitHub Actions
Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6901878427.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 28911.
recreate: .

@github-actions GitHub Actions
Copy link

Deploy-Preview-URL: https://ce-28911.dp.appsmith.com

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6901876988.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

sumitsum
sumitsum suggested changes Nov 20, 2023
View reviewed changes
...h-interfaces/src/main/java/com/appsmith/external/helpers/restApiUtils/helpers/DataUtils.java Outdated Show resolved Hide resolved
...h-interfaces/src/main/java/com/appsmith/external/helpers/restApiUtils/helpers/DataUtils.java Show resolved Hide resolved
...h-interfaces/src/main/java/com/appsmith/external/helpers/restApiUtils/helpers/DataUtils.java Outdated Show resolved Hide resolved
...h-interfaces/src/main/java/com/appsmith/external/helpers/restApiUtils/helpers/DataUtils.java Outdated Show resolved Hide resolved
...h-interfaces/src/main/java/com/appsmith/external/helpers/restApiUtils/helpers/DataUtils.java Outdated Show resolved Hide resolved
...h-interfaces/src/main/java/com/appsmith/external/helpers/restApiUtils/helpers/DataUtils.java Show resolved Hide resolved
...h-interfaces/src/main/java/com/appsmith/external/helpers/restApiUtils/helpers/DataUtils.java Outdated Show resolved Hide resolved
...ver/appsmith-plugins/restApiPlugin/src/test/java/com/external/plugins/RestApiPluginTest.java Show resolved Hide resolved
...ver/appsmith-plugins/restApiPlugin/src/test/java/com/external/plugins/RestApiPluginTest.java Show resolved Hide resolved
@sondermanish
Copy link
Contributor Author

/ok-to-test

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6942545661.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 28911.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6942545661.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Git/ExistingApps/v1.9.24/DSCrudAndBindings_Spec.ts

  2. cypress/e2e/Regression/ClientSide/Widgets/Others/StatboxDsl_spec.js
To know the list of identified flaky tests - Refer here

@sondermanish
Copy link
Contributor Author

Added issue for smart substitution to formData
#29041

@sondermanish
Copy link
Contributor Author

/ok-to-test

@sondermanish sondermanish self-assigned this Nov 22, 2023
@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6958520162.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 28911.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6958520162.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@Aishwarya-U-R Aishwarya-U-R merged commit 1fa52d3 into release Nov 23, 2023
18 of 19 checks passed
@Aishwarya-U-R Aishwarya-U-R deleted the fix/issue-28419 branch November 23, 2023 03:11
sondermanish added a commit that referenced this pull request Nov 23, 2023
@sondermanish
feat: added multipart app/json support (#28911)
02be231 
## Description
> Added multi part form data application/json support

### PR fixes following issue(s)
Fixes #28419 

#### Type of change
- Feature Improvement

#### How Has This Been Tested?
> Please describe the tests that you ran to verify your changes. Also
list any relevant details for your test configuration.
> Delete anything that is not relevant
- [x] Manual
- [x] JUnit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumitsum sumitsum sumitsum approved these changes

Assignees

@sondermanish sondermanish

Labels
Community Reported issues reported by community members Enhancement New feature or request Integrations Product Issues related to a specific integration Query & JS Pod Issues related to the query & JS Pod REST API plugin REST API plugin related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Support application/json as content type for multipart/form-data type request
3 participants
@sondermanish @sumitsum @Aishwarya-U-R