Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated loading, nodata, failed states on preview data screen #28987

Merged
merged 5 commits into from
Nov 22, 2023

Conversation

AmanAgarwal041
Copy link
Contributor

@AmanAgarwal041 AmanAgarwal041 commented Nov 21, 2023

Description

No data screen : https://www.figma.com/file/kbU9xPv44neCfv1FFo9Ndu/User-Activation?type=design&node-id=3187-16096&mode=design&t=wrfB8fCBsihx665Z-4
Screenshot 2023-11-21 at 11 39 53 AM

Loading screen : https://www.figma.com/file/kbU9xPv44neCfv1FFo9Ndu/User-Activation?type=design&node-id=3187-16224&mode=design&t=wrfB8fCBsihx665Z-4
Screenshot 2023-11-21 at 9 40 23 PM

Failed screen : https://www.figma.com/file/kbU9xPv44neCfv1FFo9Ndu/User-Activation?type=design&node-id=3187-16310&mode=design&t=wrfB8fCBsihx665Z-4
Screenshot 2023-11-21 at 11 41 26 AM

Limitation

PR fixes following issue(s)

Fixes #28986

if no issue exists, please create an issue and ask the maintainers about this first

Media

A video or a GIF is preferred. when using Loom, don’t embed because it looks like it’s a GIF. instead, just link to the video

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Chore (housekeeping or task changes that don't impact user perception)
  • This change requires a documentation update

Testing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Also list any relevant details for your test configuration.
Delete anything that is not relevant

  • Manual
  • JUnit
  • Jest
  • Cypress

Test Plan

Add Testsmith test cases links that relate to this PR

Issues raised during DP testing

Link issues raised during DP testing for better visiblity and tracking (copy link from comments dropped on this PR)

Checklist:

Dev activity

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • PR is being merged under a feature flag

QA activity:

  • Speedbreak features have been covered
  • Test plan covers all impacted features and areas of interest
  • Test plan has been peer reviewed by project stakeholders and other QA members
  • Manually tested functionality on DP
  • We had an implementation alignment call with stakeholders post QA Round 2
  • Cypress test cases have been added and approved by SDET/manual QA
  • Added Test Plan Approved label after Cypress tests were reviewed
  • Added Test Plan Approved label after JUnit tests were reviewed

@github-actions github-actions bot added Activation - datasources issues related to activation projects Bug Something isn't working Google Sheets Issues related to Google Sheets Integrations Product Issues related to a specific integration MySQL Issues related to MySQL plugin Needs Triaging Needs attention from maintainers to triage Postgres Postgres related issues Enhancement New feature or request and removed Bug Something isn't working labels Nov 21, 2023
@AmanAgarwal041
Copy link
Contributor Author

/build-deploy-preview skip-tests=true env=release

@AmanAgarwal041
Copy link
Contributor Author

/ok-to-test

Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6940001838.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: release.
PR: 28987.
recreate: .

Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6940004442.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 28987.

Copy link

Deploy-Preview-URL: https://appsmith-pmgu6yxuk-get-appsmith.vercel.app

🚨 Note: The release environment runs EE code, so using a frontend-only DP on this repo, will
likely behave unexpectedly. Consider using a full DP instead.
Learn more.

Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6940004442.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@github-actions github-actions bot added Bug Something isn't working and removed Bug Something isn't working labels Nov 21, 2023
@AmanAgarwal041
Copy link
Contributor Author

/build-deploy-preview skip-tests=true recreate=true

Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6942053219.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 28987.
recreate: true.

Copy link

Deploy-Preview-URL: https://ce-28987.dp.appsmith.com

@sneha122
Copy link
Contributor

@AmanAgarwal041 Two things:

  1. We should upload these assets.appsmith.com and use it from there
  2. Can you please check out this thread once? There was a lot of discussion and then Sumit had reverted these exact changes

@github-actions github-actions bot added the Bug Something isn't working label Nov 21, 2023
@AmanAgarwal041
Copy link
Contributor Author

/build-deploy-preview skip-tests=true recreate=true

Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6945839039.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 28987.
recreate: true.

Copy link

Deploy-Preview-URL: https://ce-28987.dp.appsmith.com

@github-actions github-actions bot removed the Bug Something isn't working label Nov 21, 2023
@github-actions github-actions bot added the Bug Something isn't working label Nov 22, 2023
@AmanAgarwal041
Copy link
Contributor Author

#28987 (comment)

  1. Updated the first
  2. Connected with @carinanfonseca and we have consensus on the states ui.

@AmanAgarwal041
Copy link
Contributor Author

/ok-to-test

Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6953811080.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 28987.

Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6953811080.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@AmanAgarwal041
Copy link
Contributor Author

Adding the Test plan approved label as it has been tested by @sneha122 and @carinanfonseca . Suggested changes by @carinanfonseca have also been addressed.

@AmanAgarwal041 AmanAgarwal041 added the Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable label Nov 22, 2023
@sumitsum sumitsum merged commit ee3edde into release Nov 22, 2023
17 of 18 checks passed
@sumitsum sumitsum deleted the fix/interim-data-states branch November 22, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Activation - datasources issues related to activation projects Bug Something isn't working Enhancement New feature or request Google Sheets Issues related to Google Sheets Integrations Product Issues related to a specific integration MySQL Issues related to MySQL plugin Needs Triaging Needs attention from maintainers to triage Postgres Postgres related issues Test Plan Approved Manual/Cypress tests covers changes made on the PR. Else, add skip-testPlan label if not applicable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Wrong Loading, Failed and Nodata states UI on preview data
3 participants