-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: updated loading, nodata, failed states on preview data screen #28987
Conversation
/build-deploy-preview skip-tests=true env=release |
/ok-to-test |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6940001838. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6940004442. |
Deploy-Preview-URL: https://appsmith-pmgu6yxuk-get-appsmith.vercel.app 🚨 Note: The release environment runs EE code, so using a frontend-only DP on this repo, will |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6940004442. |
/build-deploy-preview skip-tests=true recreate=true |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6942053219. |
Deploy-Preview-URL: https://ce-28987.dp.appsmith.com |
@AmanAgarwal041 Two things:
|
/build-deploy-preview skip-tests=true recreate=true |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6945839039. |
Deploy-Preview-URL: https://ce-28987.dp.appsmith.com |
|
/ok-to-test |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6953811080. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6953811080. |
Adding the |
Description
No data screen : https://www.figma.com/file/kbU9xPv44neCfv1FFo9Ndu/User-Activation?type=design&node-id=3187-16096&mode=design&t=wrfB8fCBsihx665Z-4
Loading screen : https://www.figma.com/file/kbU9xPv44neCfv1FFo9Ndu/User-Activation?type=design&node-id=3187-16224&mode=design&t=wrfB8fCBsihx665Z-4
Failed screen : https://www.figma.com/file/kbU9xPv44neCfv1FFo9Ndu/User-Activation?type=design&node-id=3187-16310&mode=design&t=wrfB8fCBsihx665Z-4
Limitation
PR fixes following issue(s)
Fixes #28986
Media
Type of change
Testing
How Has This Been Tested?
Test Plan
Issues raised during DP testing
Checklist:
Dev activity
QA activity:
Test Plan Approved
label after Cypress tests were reviewedTest Plan Approved
label after JUnit tests were reviewed