chore: Integrate Radio Group #29026
chore: Integrate Radio Group #29026
Conversation
jsartisan
requested review from
a team and
ashit-rath
and removed request for
a team
github-actions
bot
added
WDS team
Anvil Pod
| @@ -1,28 +1,19 @@ | |||
| import React, { forwardRef } from "react"; | |||
| import { Field } from "@design-system/headless"; | |||
There was a problem hiding this comment.
just changing, reordering imports to satisfy my ODC
| @@ -22,7 +22,7 @@ | |||
| * DISABLED | |||
| *----------------------------------------------------------------------------- | |||
| */ | |||
| &[data-disabled] { | |||
| &[data-disabled]:not([data-field-type="field-group"] &) { | |||
There was a problem hiding this comment.
we need to do it so that we don't apply opacity on field level and inline label again.
| @@ -83,16 +83,12 @@ export const propertyPaneContentConfig = [ | |||
| validation: { type: ValidationTypes.TEXT }, | |||
| }, | |||
| { | |||
| helpText: "Sets the label position of the widget", | |||
There was a problem hiding this comment.
removing and moving this prop to styles
| { label: "Right", value: "right" }, | ||
| ], | ||
| isBindProperty: false, | ||
| helpText: "Show help text or details about current input", |
There was a problem hiding this comment.
adding the missing tooltip prop
| return ( | ||
| <SwitchGroupComponent | ||
| defaultSelectedValues={this.props.defaultSelectedValues} |
There was a problem hiding this comment.
note i deleted the component in these widgets we don't need to create separate components and their types. SwitchGroup, CheckboxGroup and RadioGroup are straight forward components that don't need another encapsulation.
|
/build-deploy-preview |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/6956436707. |
|
Deploy-Preview-URL: https://ce-29026.dp.appsmith.com |
| return ( | ||
| <SwitchGroupComponent | ||
| defaultSelectedValues={this.props.defaultSelectedValues} |
|
/ok-to-test |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/6966297691. |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/6966297691. |
Fixes #29001