Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Cypress Entity Explorer Presence functions #29154

Merged
merged 14 commits into from
Nov 29, 2023
Merged

refactor: Cypress Entity Explorer Presence functions #29154

merged 14 commits into from
Nov 29, 2023

Conversation

hetunandu
Copy link
Member

@hetunandu hetunandu commented Nov 28, 2023 •
edited
Loading

Description

Refactors the following functions to improve future edits

  • Assert Presence / Absence of Entity in Explorer
  • Expand Collapse Items in Explorer
  • Separate the Page related functions in a different file

PR fixes following issue(s)

Fixes #29194

@hetunandu
Copy link
Member Author

/ok-to-test

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7015232507.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 29154.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7015232507.
Commit: ``.
Cypress dashboard url: Click here!
It seems like there are some failures 😔. We are not able to recognize it, please check this manually here.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7015232507.
Commit: ``.
Cypress dashboard url: Click here!
It seems like there are some failures 😔. We are not able to recognize it, please check this manually here.

@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@hetunandu
fix it check
36384d5
@hetunandu
Merge branch 'release' into refactor/entity-assert-presence
afa4c5c 
# Conflicts:
#	app/client/cypress/e2e/Regression/ClientSide/AppNavigation/NavigationSettings_spec.ts
#	app/client/cypress/e2e/Regression/ClientSide/BugTests/DatasourceSchema_spec.ts
#	app/client/cypress/e2e/Regression/ClientSide/ExplorerTests/Scrolling_Spec.ts
#	app/client/cypress/e2e/Regression/ClientSide/Git/GitSync/DeleteBranch_spec.js
#	app/client/cypress/e2e/Regression/ClientSide/Linting/BasicLint_spec.ts
#	app/client/cypress/e2e/Regression/ClientSide/OneClickBinding/PropertyControl_spec.ts
#	app/client/cypress/e2e/Regression/ClientSide/Refactoring/Refactoring_spec.ts
#	app/client/cypress/e2e/Regression/ClientSide/Widgets/Modal/Modal_functionaliy_spec.js
#	app/client/cypress/e2e/Regression/ClientSide/Widgets/Others/StatBox_DragAndDrop_spec.js
#	app/client/cypress/e2e/Regression/ClientSide/Widgets/Statbox/Statbox_spec.ts
#	app/client/cypress/e2e/Regression/ServerSide/ApiTests/API_Edit_spec.js
#	app/client/cypress/e2e/Regression/ServerSide/ApiTests/API_Search_spec.js
#	app/client/cypress/e2e/Regression/ServerSide/ApiTests/API_Styles_spec.js
#	app/client/cypress/e2e/Regression/ServerSide/Datasources/Oracle_Spec.ts
#	app/client/cypress/e2e/Regression/ServerSide/GenerateCRUD/MongoURI_Spec.ts
#	app/client/cypress/e2e/Regression/ServerSide/GenerateCRUD/MySQL1_Spec.ts
#	app/client/cypress/e2e/Regression/ServerSide/GenerateCRUD/Postgres1_Spec.ts
#	app/client/cypress/e2e/Regression/ServerSide/MySQL_Datatypes/Basic_Spec.ts
#	app/client/cypress/e2e/Regression/ServerSide/OnLoadTests/JsOnLoad3_Spec.ts
#	app/client/cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Array_Spec.ts
#	app/client/cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Json_Spec.ts
#	app/client/cypress/e2e/Regression/ServerSide/Postgres_DataTypes/UUID_Spec.ts
#	app/client/cypress/e2e/Sanity/Datasources/MockDBs_Spec.ts
#	app/client/cypress/support/Pages/DataSources.ts
#	app/client/cypress/support/Pages/EditorNavigation.ts
#	app/client/cypress/support/Pages/EntityExplorer.ts
#	app/client/cypress/support/Pages/IDE/LeftPane.ts
#	app/client/cypress/support/commands.js
@hetunandu
Copy link
Member Author

/ok-to-test

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7018084029.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 29154.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7018084029.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/BugTests/Bug29131_spec.ts

  2. cypress/e2e/Regression/ClientSide/ExplorerTests/Hide_Page_spec.js
  3. cypress/e2e/Regression/ClientSide/IDE/Canvas_Context_Selected_Widgets_spec.js
  4. cypress/e2e/Regression/ClientSide/Widgets/Button/Button_onClickAction_spec.js
  5. cypress/e2e/Regression/ClientSide/Widgets/Filepicker/FilePickerV2_spec.js
  6. cypress/e2e/Regression/ClientSide/Widgets/Modal/Modal_functionaliy_spec.js
  7. cypress/e2e/Regression/ClientSide/Widgets/Others/StatboxDsl_spec.js
  8. cypress/e2e/Regression/ClientSide/Widgets/TableV1/Table_Button_Icon_validation_spec.js
  9. cypress/e2e/Regression/ClientSide/Widgets/TableV2/TableV2_Button_Icon_validation_spec.js
  10. cypress/e2e/Regression/ServerSide/OnLoadTests/PostgresConnections_spec.ts
  11. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Binary_Spec.ts
  12. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Character_Spec.ts
  13. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/DateTime_Spec.ts
  14. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Json_Spec.ts
  15. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Numeric_Spec.ts
  16. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/UUID_Spec.ts
To know the list of identified flaky tests - Refer here

@hetunandu
Copy link
Member Author

/ok-to-test

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7028166863.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 29154.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7028166863.
Commit: ``.
Cypress dashboard url: Click here!
It seems like there are some failures 😔. We are not able to recognize it, please check this manually here.

@hetunandu
Copy link
Member Author

/ok-to-test

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7028538412.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 29154.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7028538412.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Widgets/Button/Button_onClickAction_spec.js

  2. cypress/e2e/Regression/ClientSide/Widgets/Others/StatboxDsl_spec.js
  3. cypress/e2e/Regression/ServerSide/Postgres_DataTypes/Json_Spec.ts
To know the list of identified flaky tests - Refer here

@github-actions github-actions bot added IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE labels Nov 29, 2023
@hetunandu
Copy link
Member Author

/ok-to-test

@github-actions GitHub Actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7030031825.
Workflow: Appsmith External Integration Test Workflow.
Commit: ``.
PR: 29154.

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7028538412.
Commit: ``.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

@hetunandu hetunandu changed the title Refactor/entity assert presence refactor: Cypress Entity Explorer Presence functions Nov 29, 2023
@hetunandu hetunandu added skip-changelog Adding this label to a PR prevents it from being listed in the changelog skip-docs skip-testPlan labels Nov 29, 2023
@github-actions github-actions bot removed the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Nov 29, 2023
@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7030031825.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Widgets/Audio/AudioRecorder1_spec.ts

  2. cypress/e2e/Regression/ClientSide/Widgets/List/List1_spec.js
  3. cypress/e2e/Regression/ServerSide/OnLoadTests/JSOnLoad2_Spec.ts
  4. cypress/e2e/Sanity/Datasources/PostgresDatasource_spec.js
To know the list of identified flaky tests - Refer here

@github-actions GitHub Actions
Copy link

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7030031825.
Commit: ``.
Cypress dashboard: Click here!
The following are new failures, please fix them before merging the PR:

  1. cypress/e2e/Regression/ClientSide/Widgets/List/List1_spec.js

To know the list of identified flaky tests - Refer here

@hetunandu hetunandu marked this pull request as ready for review November 29, 2023 10:19
@hetunandu hetunandu merged commit 0f3edc9 into release Nov 29, 2023
30 of 32 checks passed
@hetunandu hetunandu deleted the refactor/entity-assert-presence branch November 29, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aishwarya-U-R Aishwarya-U-R Aishwarya-U-R approved these changes

@rajatagrawal rajatagrawal Awaiting requested review from rajatagrawal

Assignees
No one assigned
Labels
IDE Navigation Issues/feature requests related to IDE navigation, and context switching IDE Pod Issues that new developers face while exploring the IDE skip-docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Further refactor Existing Navigation related Test code
2 participants
@hetunandu @Aishwarya-U-R