fix: JS library not found in view mode after importing from Git #29297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughWalkthroughThe changes involve an update to the application import process from Git in Appsmith, where a new step to publish the application has been added. Additionally, there are updates to the test suite to reflect this new behavior, specifically by adding an assertion to check the size of a list named Changes
Assessment against linked issues
TipsChat with CodeRabbit Bot (
|
github-actions
bot
added
Git Platform Pod
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
app/server/appsmith-server/src/test/java/com/appsmith/server/services/ce/GitServiceCETest.java
Outdated
Show resolved
Hide resolved
app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/GitServiceCEImpl.java
Show resolved
Hide resolved
app/server/appsmith-server/src/main/java/com/appsmith/server/services/ce/GitServiceCEImpl.java
Show resolved
Hide resolved
|
/ok-to-test |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7096338202. |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7096338202. |
|
@coderabbitai resolve |
|
/ok-to-test sha=43e1bc5 |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7100864566. |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7100864566.
|
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7100864566.
|
AnaghHegde
approved these changes
Dec 6, 2023
|
/ok-to-test |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7124096542. |
|
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/7124096597. |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7124096542. |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7124096597.
To know the list of identified flaky tests - Refer here |
|
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/7124096597. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If an application has a custom js library set, it's not available in view mode right after importing the application from git. User need to add a commit to make it available in Git. This PR performs a publish application operation right after git import so that any resource available in edit mode is also available in view mode.
PR fixes following issue(s)
Fixes #29278
Media
Type of change
Testing
How Has This Been Tested?
Test Plan
Issues raised during DP testing
Checklist:
Dev activity
QA activity:
Test Plan Approvedlabel after Cypress tests were reviewedTest Plan Approvedlabel after JUnit tests were reviewedSummary by CodeRabbit
New Features
Tests