-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change appsmith alias #35349
fix: change appsmith alias #35349
Conversation
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 245 files out of 300 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
@KelvinOm why is there a need for this change? Also, you haven't updated the |
@ankitakinger Fixed the lint rule. You can find the full context of this decision here. |
e9bceda
to
b3108d7
Compare
b3108d7
to
2b00af2
Compare
In order to unify package names, we decided to use
@appsmith
prefix as a marker to indicate that packages belong to our codebase and that these packages are developed internally. So that we can use this prefix, we need to rename the alias of the same name. But since@appsmith
is currently being used as an alias foree
folder, we have to rename the alias as the first step.Related discussion https://theappsmith.slack.com/archives/CPG2ZTXEY/p1722516279126329
EE PR — https://github.com/appsmithorg/appsmith-ee/pull/4801
Automation
/ok-to-test tags="@tag.All"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10267368821
Commit: 2b00af2
Cypress dashboard.
Tags:
@tag.All
Spec:
Tue, 06 Aug 2024 14:24:22 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?