fix: Pencil icon appearing in application name

[albinAppsmith]

Description

PR address below issues

1. Edit icon appearing next to application name
2. No cursor pointer for edit icon

Fixes #35878

Automation

/ok-to-test tags="@tag.All"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10562542656
Commit: 31ab617
Cypress dashboard.
Tags: @tag.All
Spec:

---

Mon, 26 Aug 2024 19:15:19 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

• Yes
• No

Summary by CodeRabbit

• New Features

  • Enhanced the EditableTextSubComponent by making the icon interactive with a cursor pointer style.
  • Introduced an optional hideEditIcon property for the EditableAppNameProps, allowing for conditional visibility of the edit icon.
  • Updated the EditorName component to accept the new hideEditIcon prop for improved customization.

• Improvements

  • Improved user interface flexibility and customization options for editing components.

[coderabbitai]

Walkthrough

The changes involve updates to the EditableTextSubComponent and EditorName components. The Icon component now includes a className to indicate interactivity, while the EditorName component gains a new optional prop, hideEditIcon, allowing for customizable display of the edit icon. These modifications enhance flexibility and user experience without altering the core functionality of the components.

Changes

Files	Change Summary
app/client/packages/design-system/ads-old/src/EditableTextSubComponent/index.tsx	Added className="cursor-pointer" to the Icon component for indicating interactivity.
app/client/src/pages/Editor/EditorName/EditableName.tsx	Introduced an optional property hideEditIcon to EditableAppNameProps for conditional rendering of the edit icon.
app/client/src/pages/Editor/EditorName/index.tsx	Updated the EditorName component to accept the new prop hideEditIcon, enhancing its flexibility in rendering.

Assessment against linked issues

Objective	Addressed	Explanation
Appropriate cursor appears when hovering over the pencil icon ( #35878)	✅

Poem

In the realm of code, a change takes flight,
A cursor now dances, a joyful sight.
Icons that beckon, with a click so bright,
Editable names, now a customizable delight.
With props that empower, our components unite! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between eda63fe and 31ab617.

Files selected for processing (3)

• app/client/packages/design-system/ads-old/src/EditableTextSubComponent/index.tsx (1 hunks)
• app/client/src/pages/Editor/EditorName/EditableName.tsx (1 hunks)
• app/client/src/pages/Editor/EditorName/index.tsx (1 hunks)

Files skipped from review due to trivial changes (1)

• app/client/packages/design-system/ads-old/src/EditableTextSubComponent/index.tsx

Additional comments not posted (2)

app/client/src/pages/Editor/EditorName/EditableName.tsx (1)

25-25: Great addition!

The hideEditIcon property enhances the flexibility of the component by allowing the edit icon to be conditionally hidden.

The code changes are approved.

app/client/src/pages/Editor/EditorName/index.tsx (1)

126-126: Excellent enhancement!

The hideEditIcon prop enhances the flexibility of the EditorName component by allowing the edit icon to be conditionally hidden.

The code changes are approved.