fix: Action redesign/remove container query #36014

albinAppsmith · 2024-08-30T10:47:08Z

Description

PR addresses below issues,

Query was not scrollable when code editor field dynamically increase height. This was caused by the container property in Section. Container will ignore absolute positioned elements dynamic heights.
Fixed code editor field min-width while resizing
Fixed ads select feild min-width while resizing.

Fixes #36000
Fixes #35901

Automation

/ok-to-test tags="@tag.Sanity, @tag.IDE"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/10631460963
Commit: 9d9fe76
Cypress dashboard.
Tags: @tag.Sanity, @tag.IDE
Spec:

Fri, 30 Aug 2024 11:24:13 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

Yes
No

Summary by CodeRabbit

New Features
- Enhanced styling for the dynamic text field control, improving visual consistency.
- Introduced a flexible grid layout for better responsiveness across different screen sizes.
Bug Fixes
- Addressed layout issues with minimum width adjustments for dynamic text fields and advertisement selectors.

…o action-redesign/remove-container-query

coderabbitai · 2024-08-30T10:47:17Z

Walkthrough

The recent changes involve updates to the DynamicTextControl class for improved styling, adjustments to CSS for better responsiveness, and modifications to the grid layout. These enhancements aim to resolve UI issues and improve the overall user experience, particularly in relation to dynamic text fields and layout adaptability.

Changes

File Path	Change Summary
`app/client/src/components/formControls/...`	Updated `className` in `DynamicTextControl` to include `dynamic-text-field-control` for enhanced styling.
`app/client/src/pages/Editor/ActionForm/Zone/...`	Modified `grid-template-columns` for better responsiveness; added styles for `.dynamic-text-field-control`.

Assessment against linked issues

Objective	Addressed	Explanation
Update container query to grid - fix for scroll issue in UQI (#36000)	✅
Action redesign - UI issues with mongo plugin (#35901)	✅

🎉 In the code, a dance of change,
Styles and props, all rearranged.
A button now shines with new delight,
Grids adjust to fit just right.
With every tweak, the UI sings,
A better app, oh what joy it brings! 🎈

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

app/client/src/components/formControls/DynamicTextFieldControl.tsx

albinAppsmith · 2024-08-30T10:53:09Z

/build-deploy-preview skip-test=true

github-actions · 2024-08-30T10:53:34Z

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/10631433861.
Workflow: On demand build Docker image and deploy preview.
skip-tests: . env: .
PR: 36014.
recreate: .

coderabbitai

Actionable comments posted: 1

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 826a33a and 4f4cd3e.

Files selected for processing (4)

app/client/src/components/formControls/DynamicTextFieldControl.tsx (1 hunks)
app/client/src/components/formControls/FieldArrayControl.tsx (1 hunks)
app/client/src/pages/Editor/ActionForm/Section/styles.module.css (1 hunks)
app/client/src/pages/Editor/ActionForm/Zone/styles.module.css (2 hunks)

Files skipped from review due to trivial changes (1)

app/client/src/pages/Editor/ActionForm/Section/styles.module.css

Additional comments not posted (4)

app/client/src/pages/Editor/ActionForm/Zone/styles.module.css (2)

8-8: Refinement of grid layout for better responsiveness.

The change to grid-template-columns using auto-fill and minmax is a smart move, ensuring that the layout adapts dynamically to the available space. This should significantly improve the responsiveness of the UI.

56-58: Resetting minimum width for advertisement selectors.

Unsetting the minimum width for .ads-v2-select > .rc-select-selector is a good approach to make the advertisement selectors more adaptable to various screen sizes. This change should help prevent UI layout issues when resizing.

app/client/src/components/formControls/DynamicTextFieldControl.tsx (1)

68-68: Enhancement to class naming for dynamic text field control.

Adding dynamic-text-feild-control to the class name of the Wrapper component allows for more specific styling and potentially better functionality. This is a straightforward and effective way to enhance the component's adaptability and maintainability by separating concerns through CSS.

app/client/src/components/formControls/FieldArrayControl.tsx (1)

103-103: Introduction of isIconButton prop to enhance semantic clarity.

Adding the isIconButton prop to the CenteredIconButton component is a thoughtful enhancement. It clarifies the component's role and usage within the UI, which can help in future maintenance and potentially optimize rendering by providing more context to the styling logic.

coderabbitai · 2024-08-30T10:53:37Z

app/client/src/pages/Editor/ActionForm/Zone/styles.module.css

+  /* Remove when code editor min width is resolved in DynamicTextFeildControl */
+  & :global(.dynamic-text-feild-control) {
+    min-width: 260px;


Set minimum width for dynamic text field control.

Setting a minimum width of 260px for the .dynamic-text-feild-control class is a temporary fix to ensure that elements do not become too small on narrower screens. However, it's crucial to address this in the DynamicTextFeildControl component itself to avoid hard-coded values in the CSS, which can lead to maintenance issues.

Consider implementing a more flexible solution within the component logic rather than relying on CSS overrides.

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4f4cd3e and 9d9fe76.

Files selected for processing (2)

app/client/src/components/formControls/DynamicTextFieldControl.tsx (1 hunks)
app/client/src/pages/Editor/ActionForm/Zone/styles.module.css (2 hunks)

Files skipped from review as they are similar to previous changes (2)

app/client/src/components/formControls/DynamicTextFieldControl.tsx
app/client/src/pages/Editor/ActionForm/Zone/styles.module.css

github-actions · 2024-08-30T11:06:16Z

Deploy-Preview-URL: https://ce-36014.dp.appsmith.com

albinAppsmith added 3 commits August 30, 2024 14:55

fix: Removed container queries and implemented grid

729717a

fix: array feils fixes

dcd2413

Merge branch 'release' of https://github.com/appsmithorg/appsmith int…

4f4cd3e

…o action-redesign/remove-container-query

albinAppsmith changed the title ~~Action redesign/remove container query~~ fix: Action redesign/remove container query Aug 30, 2024

albinAppsmith requested a review from hetunandu August 30, 2024 10:47

github-actions bot added Bug Something isn't working and removed Bug Something isn't working labels Aug 30, 2024

hetunandu reviewed Aug 30, 2024

View reviewed changes

app/client/src/components/formControls/DynamicTextFieldControl.tsx Outdated Show resolved Hide resolved

fix: spell mistake

9d9fe76

coderabbitai bot reviewed Aug 30, 2024

View reviewed changes

albinAppsmith requested a review from hetunandu August 30, 2024 10:55

albinAppsmith added the ok-to-test Required label for CI label Aug 30, 2024

hetunandu approved these changes Aug 30, 2024

View reviewed changes

coderabbitai bot reviewed Aug 30, 2024

View reviewed changes

albinAppsmith merged commit a9ca63c into release Aug 30, 2024
49 checks passed

albinAppsmith deleted the action-redesign/remove-container-query branch August 30, 2024 11:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Action redesign/remove container query #36014

fix: Action redesign/remove container query #36014

albinAppsmith commented Aug 30, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented Aug 30, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

albinAppsmith commented Aug 30, 2024

github-actions bot commented Aug 30, 2024

coderabbitai bot left a comment

coderabbitai bot Aug 30, 2024

coderabbitai bot left a comment

github-actions bot commented Aug 30, 2024

fix: Action redesign/remove container query #36014

fix: Action redesign/remove container query #36014

Conversation

albinAppsmith commented Aug 30, 2024 • edited by github-actions bot Loading

Description

Automation

🔍 Cypress test results

Communication

Summary by CodeRabbit

coderabbitai bot commented Aug 30, 2024 • edited Loading

Walkthrough

Changes

Assessment against linked issues

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

albinAppsmith commented Aug 30, 2024

github-actions bot commented Aug 30, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Aug 30, 2024

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 30, 2024

albinAppsmith commented Aug 30, 2024 •

edited by github-actions bot

Loading

coderabbitai bot commented Aug 30, 2024 •

edited

Loading