Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Example12 - create a VecGeom geometry from Geant4 #139

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jonapost
Copy link
Contributor

@jonapost jonapost commented Sep 8, 2021

This example will read a geometry using the Geant4 GDML reader, and then convert it to VecGeom in memory using the G4VecGeomNav repository's G4VecGeomConverter class.

This was modified to set the Material Index in MaterialPtr of VecGeom's LogicalVolume and the (G4HepEM) Material Cuts Couple index in LogicalVolume's MateriaCutsPtr.

Current state: WORK IN PROGRESS - not guaranteed to compile or work.

I will extract the part where the geometry is converted from Geant4 to VecGeom, and try it out in example13 instead of adding this example.

@phsft-bot
Copy link

Can one of the admins verify this patch?

@hahnjo hahnjo marked this pull request as draft September 28, 2021 12:31
@agheata
Copy link
Contributor

agheata commented Oct 17, 2023

@jonapost is this example still relevant/pursued?

@jonapost
Copy link
Contributor Author

Yes, it's relevant - as far as I know.

@WitekPokorski
Copy link
Contributor

I doubt is relevant if it was not touched for 2 years (!!!). I do not see a point keeping such old stuff which will be never completed.

@agheata
Copy link
Contributor

agheata commented Oct 18, 2023

@jonapost when I asked about being relevant I was referring to the fact that the PR is based on an old example, which itself is not so relevant anymore. I can see the merit in having the geometry read only once from GDML, but I wanted to understand if the G4 to VecGeom converter is more or less ready and if we are planning to do any work on this integration in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants