Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example17 Randomized particle gun #254

Merged
merged 4 commits into from
Jul 6, 2023
Merged

Example17 Randomized particle gun #254

merged 4 commits into from
Jul 6, 2023

Conversation

JuanGonzalezCaminero
Copy link
Contributor

  • Adds the option to shoot particles uniformly in the chosen Phi/Theta ranges
  • Adds the option to define a list of particles to be shot, and choose one at random each time
  • Includes a necessary extra check in the SteppingAction for particles going out of the world

@phsft-bot
Copy link

Can one of the admins verify this patch?

agheata
agheata requested changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@agheata agheata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments on the fractional weights and make a test that this generates as expected. To be checked also that the generator re initializes the seed befor starting the run with G4-only.

examples/Example17/include/PrimaryGeneratorAction.hh Outdated Show resolved Hide resolved
examples/Example17/include/PrimaryGeneratorAction.hh Outdated Show resolved Hide resolved
examples/Example17/macros/example17.mac.in Show resolved Hide resolved
examples/Example17/src/DetectorMessenger.cc Outdated Show resolved Hide resolved
examples/Example17/src/ParticleGun.cc Outdated Show resolved Hide resolved
examples/Example17/src/ParticleGun.cc Outdated Show resolved Hide resolved
examples/Example17/src/ParticleGun.cc Outdated Show resolved Hide resolved
JuanGonzalezCaminero and others added 4 commits July 5, 2023 15:13
@JuanGonzalezCaminero
Randomized Particle Gun
9ff96a7 
* Adds the option to shoot particles uniformly in the chosen Phi/Theta ranges
* Adds the option to define a list of particles to be shot, and choose one at random each time
@JuanGonzalezCaminero
Add out of world check in SteppingAction
7df5251
@JuanGonzalezCaminero
Add a setter for the RNG seed
335b2b0
@JuanGonzalezCaminero
Example17 EventAction, restore IO settings after output of energy dep…
60956a2 
…osits
@agheata agheata merged commit ff957c5 into apt-sim:master Jul 6, 2023
1 check passed
@JuanGonzalezCaminero JuanGonzalezCaminero deleted the new-gun-pr branch November 6, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agheata agheata agheata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuanGonzalezCaminero @phsft-bot @agheata